Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

질문폼 생성 후, 회원가입 안내 페이지로 이동 #169

Merged
merged 12 commits into from
May 26, 2023

Conversation

sumi-0011
Copy link
Member

🤔 해결하려는 문제가 무엇인가요?

질문폼 생성 후, 회원가입 안내 페이지로 이동

🎉 변경 사항

  • 추가한 질문들을 서버에 보내줄 형태로 가공하였어요.
  • 이대로 생성하기 버튼을 클릭하면 Dialog가 뜨고, 를 선택하면
  • 가공한 데이터를 로컬스토리지에 저장하고, 회원가입 안내 페이지로 이동합니다.

🙏 여기는 꼭 봐주세요!

  • 밑과 같이 사용해서 로컬스토리지 저장 용도로만 hook을 사용하였는데, 괜찮은 방식일까요?
const [_, setCreateSurveyRequest] = useLocalStorage<QuestionRequest[]>('createSurveyRequest', []);

@sumi-0011 sumi-0011 changed the base branch from main to feat/create-dialog May 26, 2023 16:14
@github-actions
Copy link

github-actions bot commented May 26, 2023

Bundle Sizes

Compared against 98215d6

Route Size (gzipped) Diff
/survey/join 76.77 KB added

Dynamic import: No significant changes found

@sumi-0011 sumi-0011 added the feat New feature or request label May 26, 2023
Copy link
Member

@hyesungoh hyesungoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯


const [customItems, setCustomsItems] = useState<QuestionItem[]>([]);

const [_, setCreateSurveyRequest] = useLocalStorage<QuestionRequest[]>('createSurveyRequest', []);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저는 이렇게 튜플 형식으로 반환될 때 언더스코어 자주 쓰긴 해요 ~~ 👍 👍

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (98215d6) 92.52% compared to head (4cc08d0) 92.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #169   +/-   ##
=======================================
  Coverage   92.52%   92.52%           
=======================================
  Files          38       38           
  Lines         281      281           
  Branches       52       52           
=======================================
  Hits          260      260           
  Misses         21       21           
Impacted Files Coverage Δ
src/hooks/router/useInternalRouter.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Base automatically changed from feat/create-dialog to main May 26, 2023 16:25
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 26, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4cc08d0
Status: ✅  Deploy successful!
Preview URL: https://4f62505d.na-lab.pages.dev
Branch Preview URL: https://feat-creat-form.na-lab.pages.dev

View logs

@sumi-0011 sumi-0011 merged commit d5e696b into main May 26, 2023
@sumi-0011 sumi-0011 deleted the feat/creat-form branch May 26, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants