Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

받은 피드백 최신순 정렬 #436

Merged
merged 1 commit into from
Aug 15, 2023
Merged

받은 피드백 최신순 정렬 #436

merged 1 commit into from
Aug 15, 2023

Conversation

hyesungoh
Copy link
Member

🤔 해결하려는 문제가 무엇인가요?

  • 사용 편의성을 위해 받은 피드백을 최신순으로 정렬해요

🎉 변경 사항

기존의 자료구조 ([year][month])를 유지하며 적용해서 조금 보기 껄끄러워진 감이 없지 않아 있어요

이후 서버 스펙을 변경하던가, 재가공하는 훅에 위임해서

컴포넌트단에서는 그리기만하는 로직으로 리팩토링하면 좋을 거 같아요

🌄 스크린샷

스크린샷 2023-08-15 오후 4 01 56

@hyesungoh hyesungoh added the feat New feature or request label Aug 15, 2023
@hyesungoh hyesungoh self-assigned this Aug 15, 2023
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (fe896d8) 89.34% compared to head (22fae94) 89.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #436   +/-   ##
=======================================
  Coverage   89.34%   89.34%           
=======================================
  Files          44       44           
  Lines         338      338           
  Branches       61       61           
=======================================
  Hits          302      302           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

Bundle Sizes

Compared against fe896d8

Route: No significant changes found

Dynamic import: No significant changes found

@hyesungoh hyesungoh merged commit 2f099e0 into main Aug 15, 2023
12 checks passed
@hyesungoh hyesungoh deleted the feat/reverse-feedback branch August 15, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants