Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button, CTAButton #84

Merged
merged 10 commits into from
May 20, 2023
Merged

Button, CTAButton #84

merged 10 commits into from
May 20, 2023

Conversation

hyesungoh
Copy link
Member

🤔 해결하려는 문제가 무엇인가요?

close #75

🎉 변경 사항

  • Button 컴포넌트를 만들었어요

  • CTAButton 컴포넌트를 만들었어요

  • __storybook__/Provider를 만들었어요.
    스토리북에서 자주 사용되는 ThemeProvider, Font, Layout을 적용해요

  • theme.transition.defaultEasing을 추가했어요
    constants/motions/defaultEasing을 css에서 사용할 수 있게 위함이에요.

🙏 여기는 꼭 봐주세요!

  • 사실 CTAButton 컴포넌트가 하는 일은 Button에 width: 100% 를 적용한 것 밖에 없어요
    Button에 size 같은 props를 추가해서 대응할 수도 있다고 생각이 되어서 .. 방법이 적절한지가 고민돼요

  • 스토리북에서 전역적으로 감싸줄 수 있는 방법이 없을까요 ...
    매 스토리마다 Provider를 사용하는게 기피돼서 ...

사용 방법

스토리북을 참고해 주세요

🌄 스크린샷

스크린샷 2023-05-18 오전 2 43 17

@hyesungoh hyesungoh added the feat New feature or request label May 17, 2023
@hyesungoh hyesungoh self-assigned this May 17, 2023
@github-actions github-actions bot added the style Change style or request it label May 17, 2023
@hyesungoh hyesungoh changed the title Feat/button component Button, CTAButton May 17, 2023
@github-actions
Copy link

github-actions bot commented May 17, 2023

Bundle Sizes

Compared against 902bd6b

Route: No significant changes found

Dynamic import: None found.

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.31 🎉

Comparison is base (902bd6b) 97.71% compared to head (96ac50c) 98.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   97.71%   98.02%   +0.31%     
==========================================
  Files          27       33       +6     
  Lines         175      203      +28     
  Branches       29       33       +4     
==========================================
+ Hits          171      199      +28     
  Misses          4        4              
Impacted Files Coverage Δ
src/styles/theme.ts 100.00% <ø> (ø)
src/components/button/Button.tsx 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 17, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 96ac50c
Status: ✅  Deploy successful!
Preview URL: https://9b41f379.na-lab.pages.dev
Branch Preview URL: https://feat-button-component.na-lab.pages.dev

View logs

@github-actions github-actions bot added the test: unit Generate or update unit test label May 17, 2023
Copy link
Member

@sjoleee sjoleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#95

스토리북 전역으로 테마 설정해두었어요~~ 풀받고 수정 기기
LGTM~

@hyesungoh hyesungoh merged commit f231313 into main May 20, 2023
@hyesungoh hyesungoh deleted the feat/button-component branch May 20, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request style Change style or request it test: unit Generate or update unit test
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

버튼 컴포넌트
3 participants