refactor(toks-main): 카테고리 기능 리팩토링 및 Bug Fixed #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minsgy
changed the title
minsgy
force-pushed
the
refactor/categories
branch
from
c152c4f to
718dad3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #402 +/- ##
=====================================
Coverage ? 0.08%
=====================================
Files ? 176
Lines ? 6178
Branches ? 176
=====================================
Hits ? 5
Misses ? 6173
Partials ? 0 ☔ View full report in Codecov by Sentry. |
dengoyoon
reviewed
Feb 15, 2024
Comment on lines
+6
to
+8
| const Provider = ({ children }: StrictPropsWithChildren) => { | ||
| return <RecoilRoot>{children}</RecoilRoot>; | ||
| }; |
There was a problem hiding this comment.
리코일 루트 위치가 에러와 연관이 있었군요..!
There was a problem hiding this comment.
넵 몰랐네요 ㄷㄷ templates 시급하게 때야할듯요
Comment on lines
+8
to
+14
| type CategoriesProps = { | ||
| categories: Array<{ | ||
| categoryName: string; | ||
| isSelected: boolean; | ||
| }>; | ||
| onClick: VoidFunction; | ||
| }; |
There was a problem hiding this comment.
요건 혹시 interface로 안하고 type으로 하신 이유가 있나요?
아무래도 상관 없긴 하지만 궁금해서 질문드립니다!
There was a problem hiding this comment.
type이 변수로도 선언되어서 범용성있고 interface에 비해 희미하지만 약간 성능이 더 좋다고 들었습니다 ㅎㅎ
Comment on lines
+43
to
+58
| useLayoutEffect(() => { | ||
| setSelectedTab(0); | ||
| setSelectedLocalCategories([]); | ||
| }, [isShow]); | ||
|
|
||
| useEffect(() => { | ||
| if (isLogin && isShow && selectedLoginCategory.length > 0) { | ||
| setSelectedLocalCategories(selectedLoginCategory); | ||
| } | ||
| }, [isLogin, isShow, selectedLoginCategory]); | ||
|
|
||
| useEffect(() => { | ||
| if (selectedTemporaryCategory.length > 0 && isShow) { | ||
| setSelectedLocalCategories(selectedTemporaryCategory); | ||
| } | ||
| }, [isShow, selectedTemporaryCategory]); |
There was a problem hiding this comment.
민석님 혹시 여기 각 useEffect가 어떤 목적으로 작성되었는지 간단한 주석 추가되면 어떨까요?
추후에 알아보기 쉽지 않을까해서 남겨봅니다
dengoyoon
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 왜 PR을 올렸나요?
카테고리 컴포넌트를 리팩토링합니다.
bug fix
💁 무엇이 어떻게 바뀌나요?
💬 리뷰어분들께