Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP-39 feat: core-design에 필요한 color, drawable, font 등 추가 #14

Merged
merged 2 commits into from
Oct 14, 2022

Conversation

juhwankim-dev
Copy link
Member

@juhwankim-dev juhwankim-dev commented Oct 13, 2022

💁‍♂️ PR 내용

core-design에 필요한 color, drawable, font 등 추가

📢 전달사항

박수 아이콘은 https://www.charlezz.com/?p=44405
이 이슈로 추가하지 못했고, 디자이너 분들에게 수정 요청 해두었습니다.

해결 완료

typography는 혜인님 레포를 따라 임시로 만들었습니다.
아직 스타일 가이드가 정해진 게 없어서 아직 정의해둘 수가 없네요 😢

@juhwankim-dev juhwankim-dev requested a review from a team as a code owner October 13, 2022 15:09
@juhwankim-dev juhwankim-dev self-assigned this Oct 13, 2022
Copy link
Member

@junhaesung junhaesung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core design system 모듈과, 각 presentation 모듈에서 관리하는 리소스의 차이나 구분하는 기준이 있는지 궁금합니다.
bottom navigation bar 의 아이콘은 여러페이지에서 사용되어서 core design system 으로 분류되는건가요?

@juhwankim-dev
Copy link
Member Author

저도 말씀해주신 기준과 동일하게 생각해서 구분했습니다.
각각의 presentation 모듈에서만 쓰이는 리소스면 거기서 관리하고
여러 페이지에서 쓰인다면 core 쪽으로 옮기는 것이 맞다고 생각했습니다.

그리고 참고하고 있는 혜인님 레포에도 그렇게 되어있는 듯하여 이렇게 분류했습니다. 😊

@juhwankim-dev juhwankim-dev changed the title feat: core-design에 필요한 color, drawable, font 등 추가 DEP-39 feat: core-design에 필요한 color, drawable, font 등 추가 Oct 13, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@juhwankim-dev juhwankim-dev merged commit 0f768ae into develop Oct 14, 2022
@juhwankim-dev juhwankim-dev deleted the feature/DEP-39 branch October 14, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants