Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP-48 ui: 홈화면(목표 목록 페이지) 그리기 #15

Merged
merged 1 commit into from
Oct 15, 2022

Conversation

juhwankim-dev
Copy link
Member

💁‍♂️ PR 내용

20221015_013105
20221015_021215

목표 목록 페이지에 해당하는 ui를
뚝딱뚝딱 만들어 봤습니다.

📢 전달사항

폰트나 색상 이런 부분에 있어서 굉장히 러프하게 짰어요.
피그마에 있는 UT 가이드가 아직 체계가 안 잡혀있는 부분이 많아서
뭐 폰트를 typography나 theme로 묶는다든지
색상마다 이름이 있어서 네이밍에 적용한다든지 이런 게 불가능 하더라구요.
나중에 수정 해야 할 것 같습니다 흑

@juhwankim-dev juhwankim-dev self-assigned this Oct 14, 2022
@juhwankim-dev juhwankim-dev requested a review from a team as a code owner October 14, 2022 17:58
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@junhaesung junhaesung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@juhwankim-dev juhwankim-dev merged commit b4bc974 into develop Oct 15, 2022
@juhwankim-dev juhwankim-dev deleted the feature/DEP-48 branch October 15, 2022 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants