Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP-373 마이페이지 습관 보관함 터치 영역 넓히기, 스플래시 시간 1초 추가 #179

Merged
merged 2 commits into from
Jan 8, 2023

Conversation

juhwankim-dev
Copy link
Member

💁‍♂️ 변경 내용

AS-IS

  • 마이페이지 습관 보관함 터치가 -> 버튼에만 달려있었습니다.
  • 스플래시 시간이 1초였고, 애니메이션이 끝나면 1번 더 반복하게 되어있었습니다.

TO-BE

  • 습관보관함 터치 범위를 흰색 배경만큼 더 넓혔습니다.
  • 스플래시 시간을 2초로 늘리고 반복하지 않게 변경했습니다.

📢 전달사항

  • 해성님 코드를 제가 건드린거라서 확인한번만 부탁드려용

@juhwankim-dev juhwankim-dev added the bug Something isn't working label Jan 8, 2023
@juhwankim-dev juhwankim-dev self-assigned this Jan 8, 2023
@juhwankim-dev juhwankim-dev requested a review from a team as a code owner January 8, 2023 12:09
@@ -13,16 +13,17 @@
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent" />
app:layout_constraintTop_toTopOf="parent"
app:lottie_autoPlay="false" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와.. 이런 옵션이 있는줄 몰랐네요 ㅜ

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@juhwankim-dev juhwankim-dev merged commit 53d47d3 into develop Jan 8, 2023
@juhwankim-dev juhwankim-dev deleted the bugfix/DEP-373_touch_area branch January 8, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants