Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP-54 feat: 목표 생성 페이지 그리기 #18

Merged
merged 7 commits into from
Oct 17, 2022
Merged

DEP-54 feat: 목표 생성 페이지 그리기 #18

merged 7 commits into from
Oct 17, 2022

Conversation

kimhyeing
Copy link
Contributor

💁‍♂️ PR 내용

image

  • 이벤트 설정은 하지 않았기 때문에 (클릭이벤트, 글자수 카운팅 등) 이벤트의 결과로서 필요한 ui는 띄워지지 않습니닷!

📢 전달사항

  1. 아직 스타일가이드가 안정해져서.. 컬러값을 헥사값으로 할까 그냥 임의로 name을 설정해서 할까 하다가 name으로 설정 박아버렸습니다... 나중에 정해졌을 때 같은 값이 있으면 replace를 하려구요 (사실 화면 자체가 바뀌면 의미없는 고민이긴 합니다)
  2. switch 버튼은 커스텀이 왜 안먹히는진 모르겠는데 안먹혀서 .. 그냥 올렸습니다,,, 찐 디자인이면 끝까지 커스텀하려 했을텐데 바뀔 수도 있는 디자인일 것 같아 커스텀하지 않았습니다 -> 그러니까 뷰 간의 간격이 좁아보이네용.. 이건 오늘 회의 때 디자인 분들한테 전달하겠습니다!

@kimhyeing kimhyeing self-assigned this Oct 17, 2022
@kimhyeing kimhyeing requested a review from a team as a code owner October 17, 2022 10:23
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 17, 2022
View reviewed changes
app/src/main/AndroidManifest.xml Fixed Show resolved Hide resolved
juhwankim-dev
juhwankim-dev approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@juhwankim-dev juhwankim-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니당!! 👍👍

@kimhyeing kimhyeing closed this Oct 17, 2022
@kimhyeing kimhyeing reopened this Oct 17, 2022
@kimhyeing kimhyeing merged commit 56008c7 into develop Oct 17, 2022
@kimhyeing kimhyeing deleted the feature/DEP-54 branch October 17, 2022 11:11
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juhwankim-dev juhwankim-dev juhwankim-dev approved these changes

@junhaesung junhaesung junhaesung left review comments

Assignees

@kimhyeing kimhyeing

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kimhyeing @junhaesung @juhwankim-dev