Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP-364 config: debug, release 환경별로 변수 분리 #185

Merged
merged 10 commits into from
Jan 9, 2023
Merged

DEP-364 config: debug, release 환경별로 변수 분리 #185

merged 10 commits into from
Jan 9, 2023

Conversation

junhaesung
Copy link
Member

@junhaesung junhaesung commented Jan 8, 2023 •
edited
Loading

💁‍♂️ 변경 내용

AS-IS

  • 키값 하드코딩

TO-BE

  • 하드코딩 하던 키값을 local.properties 로 이동
  • debug, release buildType 따라 환경에 맞는 변수값 주입
  • build-property module 추가
  • BuildPropertyRepository 추가

📢 전달사항

  • data, core 모듈 2곳에서 buildType 에 따른 변수를 사용해야하는데, domain 에 관련 repository 추가하긴 애매해서 build-property 라는 모듈 새로 추가했습니다
app ---+ core ---+ build-property
   \              /
    ---+ data ----

@junhaesung junhaesung requested a review from a team as a code owner January 8, 2023 15:45
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

kimhyeing
kimhyeing approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@kimhyeing kimhyeing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드 확인 완료했습니다! 감사합니다!!!

@junhaesung junhaesung merged commit 0c8a3bd into develop Jan 9, 2023
@junhaesung junhaesung deleted the feature/DEP-364_build_configuration branch January 9, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimhyeing kimhyeing kimhyeing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@junhaesung @kimhyeing