DEP-68 feat: 목표 활성 비활성화 구현 및 버그 수정 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-android into feature/DEP-68_goal_achievement � Conflicts: � data/src/main/java/com/depromeet/threedays/data/mapper/GoalMapper.kt � domain/src/main/java/com/depromeet/threedays/domain/entity/Goal.kt
…-android into feature/DEP-68_goal_achievement � Conflicts: � data/src/main/java/com/depromeet/threedays/data/mapper/GoalMapper.kt � presentation/home/src/main/java/com/depromeet/threedays/home/home/GoalAdapter.kt � presentation/home/src/main/java/com/depromeet/threedays/home/home/GoalViewHolder.kt � presentation/home/src/main/java/com/depromeet/threedays/home/home/HomeFragment.kt � presentation/home/src/main/java/com/depromeet/threedays/home/home/HomeViewModel.kt � presentation/home/src/main/res/layout/item_goal.xml
|
Kudos, SonarCloud Quality Gate passed! |
junhaesung
approved these changes
Oct 23, 2022
| @@ -24,7 +25,7 @@ class GoalAdapter(val viewModel: HomeViewModel) : ListAdapter<Goal, GoalViewHold | |||
| companion object { | |||
| private val DIFF_UTIL = object : DiffUtil.ItemCallback<Goal>() { | |||
| override fun areItemsTheSame(oldItem: Goal, newItem: Goal): Boolean { | |||
| return oldItem.goalId == newItem.goalId | |||
| return oldItem == newItem | |||
There was a problem hiding this comment.
요거 아까 화면공유할 때 수정하신걸로봤는데 의도하신거 맞을까요?
There was a problem hiding this comment.
둘 다 제대로 작동을 안 해서 그냥 냅뒀다... 라고 보면 될 것 같습니다 😭
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💁♂️ 변경 내용
AS-IS
TO-BE
📢 전달사항
리스트는 여전히 실시간 반영이 되지 않습니다.
이것저것 다해봤는데 아무래도 DiffUtil 쪽 문제 같은데 흠... 🤔
지금 LiveData로 되어있는데 나중에 다시 Flow로 돌리겠습니다.