Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP-88 feat: 화면 간 데이터 넘기기 및 에러 수정 #33

Merged
merged 6 commits into from
Oct 24, 2022
Merged

DEP-88 feat: 화면 간 데이터 넘기기 및 에러 수정 #33

merged 6 commits into from
Oct 24, 2022

Conversation

kimhyeing
Copy link
Contributor

💁‍♂️ 변경 내용

AS-IS

  • 목표 수정이 불가능했습니다.
  • 목표 수정 화면에서 기존 목표의 데이터가 불러와지지 않았습니다
  • 추가/수정/삭제 후 ui가 실시간으로 바뀌지 않았습니다.
  • 홈 화면의 날짜 text가 고정 text였습니다.

TO-BE

  • 목표 수정이 가능합니다.
  • 목표 수정 화면에서 기존 목표의 데이터가 불러와집니다.
  • 추가/수정/삭제 후 ui가 실시간으로 바뀝니다.
  • 홈 화면의 날짜 text를 오늘 날짜 데이터를 받아 변경했습니다.

📢 전달사항

HomeViewModel 에서 update, create 같이 data class가 변경되어 에러가 나는 함수는 주석처리 해놨습니다..! @juhwankim-dev

@kimhyeing kimhyeing self-assigned this Oct 24, 2022
@kimhyeing kimhyeing requested a review from a team as a code owner October 24, 2022 08:31
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
14.9% 14.9% Duplication

@kimhyeing kimhyeing merged commit 63155bf into develop Oct 24, 2022
@kimhyeing kimhyeing deleted the feature/DEP-88 branch October 24, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kimhyeing kimhyeing

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kimhyeing