Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP-111 feat: 알림 시간 수정 가능 및 switch 버튼 기능 추가 #38

Merged
merged 2 commits into from
Oct 28, 2022

Conversation

kimhyeing
Copy link
Contributor

💁‍♂️ 변경 내용

AS-IS

  • 알림시간 수정이 불가능했습니다.
  • switch 버튼으로 목표기간/수행시간을 안보이게 할 수 있었습니다.

TO-BE

  • 알림 시간 수정이 가능합니다
  • switch 버튼으로 목표기간/수행시간을 닫은 상태로 저장/수정을 하면 그 값을 null인 상태로 저장합니다. (설정하지 않는다는 의미)

📢 전달사항

@kimhyeing kimhyeing self-assigned this Oct 28, 2022
@kimhyeing kimhyeing requested a review from a team as a code owner October 28, 2022 04:21
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
89.0% 89.0% Duplication

@kimhyeing kimhyeing merged commit 67ee673 into develop Oct 28, 2022
@kimhyeing kimhyeing deleted the feature/DEP-111 branch October 28, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant