Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP-144 ui: 디자인 가이드에 맞게 core design 재설정 #41

Merged
merged 7 commits into from
Nov 12, 2022

Conversation

juhwankim-dev
Copy link
Member

@juhwankim-dev juhwankim-dev commented Nov 11, 2022

  1. 디자인 가이드에 있는 폰트, 색상, 아이콘을 추가해보았습니다.
  2. 디자인 가이드에 있는 탭대로 모듈나누고 프래그먼트 생성해서 바텀 네비게이션이랑 연동해뒀습니다.
    (다들 열심히 하시길래 뭐라도 해보았습니다. . .)

@juhwankim-dev juhwankim-dev requested a review from a team as a code owner November 11, 2022 14:58
@juhwankim-dev juhwankim-dev self-assigned this Nov 11, 2022
@juhwankim-dev juhwankim-dev changed the title DEP-144 ui: 디자인 가이드에 정의된 요소 추가 DEP-144 ui: 디자인 가이드에 맞게 core design 재설정 Nov 11, 2022
@junhaesung
Copy link
Member

빌드 실패로 나오는것만 확인부탁드려요 👍

@juhwankim-dev
Copy link
Member Author

빌드 실패로 나오는것만 확인부탁드려요 👍

app 모듈의 min sdk는 26인데
새롭게 만든 모듈의 min sdk가 24여서 빌드 실패가 뜨고 있었네요 😅
수정해두었습니다!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@juhwankim-dev juhwankim-dev merged commit 97d0e11 into develop Nov 12, 2022
@juhwankim-dev juhwankim-dev deleted the feature/DEP-144_core_design branch November 12, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants