Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP-148 ui: 나의 기록 ui 구현 #43

Merged
merged 4 commits into from
Nov 16, 2022
Merged

DEP-148 ui: 나의 기록 ui 구현 #43

merged 4 commits into from
Nov 16, 2022

Conversation

juhwankim-dev
Copy link
Member

💁‍♂️ 변경 내용

TO-BE

20221116_010400
20221116_010419

📢 전달사항

  1. ui만 호다닥 그려봤습니다.
  2. 해성님 의견을 반영하여 의미 없는 뷰 id들을 수정했습니다.

@juhwankim-dev juhwankim-dev requested a review from a team as a code owner November 15, 2022 16:07
@juhwankim-dev juhwankim-dev self-assigned this Nov 15, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

junhaesung
junhaesung approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@junhaesung junhaesung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

목표->습관으로 바뀌었으니, object 보다는 습관을 나타내는 이름이 좀더 좋을거같아요!

@juhwankim-dev juhwankim-dev merged commit 5518da9 into develop Nov 16, 2022
@juhwankim-dev juhwankim-dev deleted the feature/DEP-148_history_ui branch November 16, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junhaesung junhaesung junhaesung approved these changes

Assignees

@juhwankim-dev juhwankim-dev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juhwankim-dev @junhaesung