DEP-158 feat: sdk version 업데이트 & 모듈명 변경 & 습관 등록/수정 UI 제작 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed. |
junhaesung
reviewed
Nov 27, 2022
| } | ||
|
|
||
| /* | ||
| private fun observe() { |
There was a problem hiding this comment.
주석부분 안쓰는 코드이면 삭제해도 좋을 것 같습니다.
There was a problem hiding this comment.
곧 기능 도입할 예정이라 주석만 해놨습니닷 늦어지면 삭제하겠습니다!!
|
|
||
| @Binds | ||
| abstract fun bindGoalAddNavigator(navi: GoalAddNavigatorImpl): GoalAddNavigator | ||
| abstract fun bindGoalAddNavigator(navi: HabitCreateNavigatorImpl): GoalAddNavigator |
There was a problem hiding this comment.
HabitCreateNavigatorImpl 대신 HabitCreateNavigator 사용하는것도 가능할까요?
특정 구현보다 추상적인 타입으로 쓰는게 좋을 것 같아서요
There was a problem hiding this comment.
interface를 navigator모듈에 작성하고 해당되는 각 모듈에서 구현체를 작성해서 impl을 하긴 했는데 (생각해보니 GoalAddNavigator라는 이름이 그대로있네요 navigator이름도 바꿔놓겠습니닷) 아직 제가 hilt에 익숙하지 않아서 그런데 구현체 대신 추상체를 넣는것도 가능한가요?? @juhwankim-dev
There was a problem hiding this comment.
저도 항상 구현체만 넣어와서
이번 기회에 테스트해봤는데 추상체는 안되네요...!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💁♂️ 변경 내용
AS-IS
TO-BE
📢 전달사항