Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP-168 습관 삭제, 수정 모달 ui 변경 #51

Merged
merged 2 commits into from
Dec 1, 2022
Merged

DEP-168 습관 삭제, 수정 모달 ui 변경 #51

merged 2 commits into from
Dec 1, 2022

Conversation

juhwankim-dev
Copy link
Member

💁‍♂️ 변경 내용

KakaoTalk_20221130_213725266

AS-IS

  • 변경 전 아이콘을 사용하고 있었습니다.
  • 문자열이 하드코딩 되어있었습니다.
  • Modal에 radius가 없었습니다.
  • 모달 layout을 LinearLayout만을 사용해 만들었습니다.

TO-BE

  • 변경 후 아이콘을 사용합니다.
  • 문자열을 strings.xml에서 가져와 사용합니다.
  • Modal에 radius가 생겼습니다.
  • 모달 layout에 ConstraintLayout을 같이 사용합니다.

@juhwankim-dev juhwankim-dev added the enhancement New feature or request label Nov 30, 2022
@juhwankim-dev juhwankim-dev requested a review from a team as a code owner November 30, 2022 12:38
@juhwankim-dev juhwankim-dev self-assigned this Nov 30, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@juhwankim-dev juhwankim-dev merged commit 585cd9f into develop Dec 1, 2022
@juhwankim-dev juhwankim-dev deleted the feature/DEP-168_edit_delete_bottom_sheet_ui branch December 10, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junhaesung junhaesung junhaesung approved these changes

Assignees

@juhwankim-dev juhwankim-dev

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juhwankim-dev @junhaesung