Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP-170 ui: 그라데이션 추가 #54

Merged
merged 4 commits into from
Dec 4, 2022

Conversation

juhwankim-dev
Copy link
Member

💁‍♂️ 변경 내용

20221204_013709

AS-IS

  • 그라데이션이 없었는데요

TO-BE

  • 그라데이션이 생겼습니다. 짜잔

📢 전달사항

이전 커밋 기록이 또 섞였는데
ui: 그라데이션 추가 이것만 보시면 됩니다.

@juhwankim-dev juhwankim-dev added the enhancement New feature or request label Dec 3, 2022
@juhwankim-dev juhwankim-dev requested a review from a team as a code owner December 3, 2022 16:39
@juhwankim-dev juhwankim-dev self-assigned this Dec 3, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@junhaesung
Copy link
Member

junhaesung commented Dec 4, 2022

작업하실 때 예전 develop 에서 브랜치 여러개 따시는거같은데,
이런거 코드 최신화할 때 머지 말고 리베이스 해보시면 어떨까요 ㅋㅋㅋ

@juhwankim-dev
Copy link
Member Author

작업하실 때 예전 develop 에서 브랜치 여러개 따시는거같은데, 이런거 코드 최신화할 때 머지 말고 리베이스 해보시면 어떨까요 ㅋㅋㅋ

rebase 뭔가 무서워서 항상 피했는데....
앞으론 해보겠습니닷

@juhwankim-dev juhwankim-dev merged commit 669fd83 into develop Dec 4, 2022
juhwankim-dev added a commit that referenced this pull request Dec 5, 2022
* chore: fragment와 viewModel 생성

* ui: 짝꿍 만들기 1단계 ui 구현

* ui: 그라데이션 추가
juhwankim-dev added a commit that referenced this pull request Dec 7, 2022
* chore: package 경로 변경

* ui: title2 폰트 추가

* ui: 사용할 문자열 strings.xml에 추가

* feat: 짝꿍 타입 선택 fragment와 viewModel 추가

* ui: 짝꿍 타입 선택 ui 구현

* DEP-170 ui: 그라데이션 추가 (#54)

* chore: fragment와 viewModel 생성

* ui: 짝꿍 만들기 1단계 ui 구현

* ui: 그라데이션 추가

* ui: 테두리가 있는 rect 도형 구현

* feat: 짝꿍 선택 상태를 주고 받는 fragment와 viewModel 구현

* chore: id 지정
@juhwankim-dev juhwankim-dev deleted the feature/DEP-170_create_mate_step_1_ui branch December 10, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants