Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP-197 feat: 알림 페이지 UI 구현 #61

Merged
merged 10 commits into from
Dec 10, 2022
Merged

DEP-197 feat: 알림 페이지 UI 구현 #61

merged 10 commits into from
Dec 10, 2022

Conversation

junhaesung
Copy link
Member

💁‍♂️ 변경 내용

AS-IS

  • 알림 목록 페이지 없음

TO-BE

  • 알림 목록 Activity 추가
  • 알림 목록 없으면 안내 문구 보여주기
  • 알림 목록 있으면 recycler view 로 목록 보여주기

📢 전달사항

페어프로그래밍하면서 주환님께 많이 도움 받았습니다 ㅋㅋㅋ

image

image

@junhaesung junhaesung requested a review from a team as a code owner December 10, 2022 10:54
@junhaesung junhaesung added the enhancement New feature or request label Dec 10, 2022
juhwankim-dev
juhwankim-dev approved these changes Dec 10, 2022
View reviewed changes
Copy link
Member

@juhwankim-dev juhwankim-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아닙니당.. 해성님이 다 하셨는걸요!
conflict 해결만 부탁드립니다

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 13 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@junhaesung junhaesung merged commit 402c4fa into develop Dec 10, 2022
@junhaesung junhaesung deleted the feature/notification-list-page branch December 10, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juhwankim-dev juhwankim-dev juhwankim-dev approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@junhaesung @juhwankim-dev