DEP-201 ui: 공유하기 페이지 UI 구현 #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
junhaesung
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💁♂️ 변경 내용
📢 전달사항
초록색 영역은 아마 지워질 수도 있습니다. (문의 넣어둔 상태)
지워지면 기능 만들 때 쏙 뺄게요.
그리고 이번에 어쩌다가
drawableTop이라는 속성을 알게 돼서 써봤는데텍스트 뷰 주변에 다가 이미지 놓을 때 쓰기 좋은 속성이더라고요...
이미 알고 계실 수도 있지만 공유해 봅니당
인스타그램 아이콘은 이상하게 svg 적용이 안돼서 문의 넣어둔 상태고
나중에 피드백 오면 수정하겠습니다. 현재는 png입니다.