DEP-195 ui: 이미지가 있는 스낵바 구현 #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junhaesung
reviewed
Dec 13, 2022
junhaesung
reviewed
Dec 15, 2022
|
|
||
| val params = layoutParams as FrameLayout.LayoutParams | ||
| params.gravity = Gravity.TOP | ||
| layoutParams = params |
There was a problem hiding this comment.
요거 지우면 lint error 도 해결되고, gravitiy 옵션도 적용됩니당!
|
Kudos, SonarCloud Quality Gate passed! |
junhaesung
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💁♂️ 변경 내용
📢 전달사항
기존의 커스텀 스낵바를 살짝 변경 시켜 만들었습니다.
하나로 통일해서 유동적으로 쓰고 싶었는데
할게 너무 많이 남아서 ㅋㅋㅋㅋㅠ 생각할 시간에 UI 하나 더 짜자 싶어서 따로 만들었습니다...
촉박하네요... 화이팅...