Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP-205 ui: 짝꿍 페이지 리뉴얼 #72

Merged
merged 6 commits into from
Dec 15, 2022

Conversation

juhwankim-dev
Copy link
Member

@juhwankim-dev juhwankim-dev commented Dec 13, 2022

💁‍♂️ 변경 내용

KakaoTalk_20221214_022605558

KakaoTalk_20221214_022605745

KakaoTalk_20221214_022605913

디자인팀의 새로운 요구 사항에 맞게 리뉴얼한 짝꿍 페이지입니다.
그리고 Display 폰트가 새로 생겨서 추가했습니다.

+) mate_fragment에 너무 많은 변화가 일어나서 깃허브에서 changed가 확인이 안되네요;;
자잘 자잘한 변경 사항을 일일이 나눠서 커밋할수도 없어서 한 번에 올렸는데...
xml이니 가볍게 대충 확인하고 넘겨주셔도 될 것 같습니다.

@juhwankim-dev juhwankim-dev added the enhancement New feature or request label Dec 13, 2022
@juhwankim-dev juhwankim-dev requested a review from a team as a code owner December 13, 2022 17:28
@juhwankim-dev juhwankim-dev self-assigned this Dec 13, 2022
@@ -47,4 +49,6 @@
<string name="save_as_image">이미지로 저장</string>
<string name="share_story">스토리 공유</string>
<string name="share_page_guide">\@ZZAKSIM 을 태그해주시면 리포스팅 해드려요</string>
<!-- TODO: Remove or change this placeholder text -->
<string name="hello_blank_fragment">Hello blank fragment</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

중요한건 아닌데, 요거 안쓰면 삭제부탁드려요

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@juhwankim-dev juhwankim-dev merged commit b40555e into develop Dec 15, 2022
@juhwankim-dev juhwankim-dev deleted the feature/DEP-205_mate_renewal branch December 15, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants