DEP-198 마이페이지 ui 적용 #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimhyeing
approved these changes
Dec 14, 2022
.../mypage/src/main/java/com/depromeet/threedays/mypage/archived_habit/ArchivedHabitActivity.kt
Outdated
Show resolved
Hide resolved
build.gradle
Outdated
| ext { | ||
| threeDaysApplicationId = "com.depromeet.threedays" | ||
| threeDaysAppVersionCode = 2 | ||
| threeDaysAppVersionName = "1.0" |
There was a problem hiding this comment.
- https://spoqa.github.io/2012/12/18/semantic-versioning.html
아직 논의되어야할 이야기이긴한데 버전 관리 1.0 대신 1.0.0 는 어떠신가요?
There was a problem hiding this comment.
@juhwankim-dev 주환님 보시고 의견 부탁드려요
There was a problem hiding this comment.
주환님도 동의하셔서 버저닝 방식 바꿨습니다 (1.0 -> 0.0.1)
QA 끝나고 심사 올릴때 버전올리면서 태그도 붙이면 좋을거같아요
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💁♂️ 변경 내용
AS-IS
TO-BE
📢 전달사항
마이페이지
닉네임 수정 (enabled)
닉네임 수정 (disabled)
습관 보관함 (작업중)