test(selenium): fix tests for handling lazy iframe #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en-html into test/fix/unloaded
michael-siek
force-pushed
the
test/fix/unloaded
branch
from
4ac3780
to
0a7b31f
Compare
michael-siek
commented
May 8, 2024
| @@ -37,19 +37,19 @@ | |||
| import org.junit.BeforeClass; | |||
There was a problem hiding this comment.
most of this was prettier
There was a problem hiding this comment.
This was likely the precommit hook that was have https://github.com/dequelabs/axe-core-maven-html/blob/develop/scripts/pre-commit-hook.sh#L6
Zidious
previously requested changes
May 8, 2024
| @@ -37,19 +37,19 @@ | |||
| import org.junit.BeforeClass; | |||
There was a problem hiding this comment.
This was likely the precommit hook that was have https://github.com/dequelabs/axe-core-maven-html/blob/develop/scripts/pre-commit-hook.sh#L6
selenium/src/test/java/com/deque/html/axecore/selenium/Axe43xIntegrationTest.java
Outdated
Show resolved
Hide resolved
michael-siek
commented
May 9, 2024
Comment on lines
634
to
662
| AxeBuilder axeBuilder = new AxeBuilder() | ||
| .withOnlyRules(Arrays.asList("label", "frame-tested")); | ||
| Results axeResults = axeBuilder.analyze(webDriver); | ||
|
|
||
| assertNotEquals(title, "Error"); | ||
| assertEquals(axeResults.getIncomplete().size(), 1); | ||
| assertEquals(axeResults.getIncomplete().get(0).getId(), "frame-tested"); | ||
| assertEquals(axeResults.getIncomplete().get(0).getNodes().size(), 1); | ||
| assertTargetEquals( | ||
| String[] expected = new String[] { "#ifr-lazy", "#lazy-iframe" }; | ||
|
|
||
| if (!axeResults.getIncomplete().isEmpty()) { | ||
| assertEquals(axeResults.getIncomplete().size(), 1); | ||
| assertEquals(axeResults.getIncomplete().get(0).getId(), "frame-tested"); | ||
| assertEquals(axeResults.getIncomplete().get(0).getNodes().size(), 1); | ||
| assertTargetEquals( | ||
| axeResults.getIncomplete().get(0).getNodes().get(0).getTarget(), | ||
| new String[] {"#ifr-lazy", "#lazy-iframe"}); | ||
| assertEquals(axeResults.getViolations().size(), 2); | ||
| assertEquals(axeResults.getViolations().get(1).getId(), "label"); | ||
| assertEquals(axeResults.getViolations().get(1).getNodes().size(), 1); | ||
| expected | ||
| ); | ||
| } else { | ||
| assertEquals(axeResults.getIncomplete().size(), 0); | ||
| assertTargetEquals( | ||
| axeResults.getPasses().get(0).getNodes().get(1).getTarget(), | ||
| expected | ||
| ); | ||
| } | ||
| assertNotEquals(title, "Error"); | ||
| assertEquals(axeResults.getViolations().size(), 1); | ||
| assertEquals(axeResults.getViolations().get(0).getId(), "label"); | ||
| assertEquals(axeResults.getViolations().get(0).getNodes().size(), 1); | ||
| assertTargetEquals( | ||
| axeResults.getViolations().get(1).getNodes().get(0).getTarget(), | ||
| new String[] {"#ifr-lazy", "#lazy-baz", "input"}); | ||
| axeResults.getViolations().get(0).getNodes().get(0).getTarget(), | ||
| new String[] { "#ifr-lazy", "#lazy-baz", "input" } | ||
| ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chrome v124 made it so we were able to test in unloaded iframes. This changes the test to handle lazy loaded iframes in chrome v124+
qa notes: test to make sure chrome v124+ test lazy loaded iframes while chrome <124 has it in incomplete