chore: update test-fixtures to fix lazy load #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-siek
reviewed
May 9, 2024
| @@ -557,7 +555,6 @@ public void withMultipleIncludes() { | |||
|
|
|||
| assertTrue(targets.stream().anyMatch(selector -> selector.equalsIgnoreCase(".include"))); | |||
| assertTrue(targets.stream().anyMatch(selector -> selector.equalsIgnoreCase(".include2"))); | |||
| assertEquals(axeResults.getPasses().get(0).getNodes().size(), 2); | |||
There was a problem hiding this comment.
In javascript land we don't check the size of the nodes but the size of the nodes are 4 instead of 2 with the new test fixtures with how they are laid out
scottmries
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the broken lazy load iframe tests.
Ref: dequelabs/axe-core-npm#1052
No QA needed.