feat(cli): replace axe-webdriverjs in favor of @axe-core/webdriverjs (#…

…51) Co-authored-by: Stephen Mathieson <me@stephenmathieson.com>
dequelabs · Jul 14, 2020 · 734a795 · 734a795
1 parent a9ccea6
commit 734a795
Show file tree

Hide file tree

Showing 7 changed files with 249 additions and 248 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -47,7 +47,7 @@ jobs:
           key: v1-root-npm-{{ checksum "package-lock.json" }}
           paths:
             - node_modules
-      - run: npm run bootstrap
+      - run: npm run bootstrap -- --ci
       - save_cache:
           key: v1-cli-npm-{{ checksum "packages/cli/package-lock.json" }}
           paths:
@@ -90,6 +90,8 @@ jobs:
     steps:
       - checkout
       - restore_dependency_cache
+      # Re-build packages, ensuring packages/webdriverjs/dist exists.
+      - run: npx lerna run prepare
       - run: npm run test --prefix=packages/cli
 
   puppeteer:

diff --git a/packages/cli/README.md b/packages/cli/README.md
@@ -20,7 +20,7 @@ After installing, you can now run the `axe` command in your CLI, followed by the
 axe https://www.deque.com
 ```
 
-You can run multiple pages at once, simply add more URLs to the command. Keep in mind that axe-cli is not a crawler, so if you find yourself testing dozens of pages at once, you may want to consider switching over to something like [axe-webdriverjs](https://www.npmjs.com/package/axe-webdriverjs). If you do not specify the protocol, http will be used by default:
+You can run multiple pages at once, simply add more URLs to the command. Keep in mind that axe-cli is not a crawler, so if you find yourself testing dozens of pages at once, you may want to consider switching over to something like [@axe-core/webdriverjs](https://www.npmjs.com/package/@axe-core/webdriverjs). If you do not specify the protocol, http will be used by default:
 
 ```
 axe www.deque.com, dequeuniversity.com

diff --git a/packages/cli/lib/axe-test-urls.js b/packages/cli/lib/axe-test-urls.js
@@ -1,7 +1,7 @@
 'use strict';
 
 const WebDriver = require('selenium-webdriver');
-const AxeBuilder = require('axe-webdriverjs');
+const AxeBuilder = require('@axe-core/webdriverjs');
 
 function testPages(urls, config, events) {
   const driver = config.driver;

diff --git a/packages/cli/package-lock.json b/packages/cli/package-lock.json
diff --git a/packages/cli/package.json b/packages/cli/package.json
@@ -34,8 +34,8 @@
     "url": "http://github.com/wilcofiers/"
   },
   "dependencies": {
+    "@axe-core/webdriverjs": "4.0.0-pre.0",
     "axe-core": "^3.2.2",
-    "axe-webdriverjs": "^2.2.0",
     "chromedriver": "latest",
     "colors": "^1.4.0",
     "commander": "^2.19.0",

diff --git a/packages/webdriverjs/package-lock.json b/packages/webdriverjs/package-lock.json
diff --git a/packages/webdriverjs/package.json b/packages/webdriverjs/package.json
@@ -55,7 +55,7 @@
     "test:sauce": "mocha test/sauce/*.js --require babel-register",
     "coverage": "nyc npm run test:unit",
     "build": "babel lib --out-dir dist",
-    "prepublishOnly": "npm run build"
+    "prepare": "npm run build"
   },
   "peerDependencies": {
     "selenium-webdriver": ">= 2.53.1"