fix(cli): Enable program to work with pkg
#48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
reviewed
Jul 10, 2020
packages/cli/lib/axe-test-urls.js
Outdated
Comment on lines
33
to
35
| const callback = arguments[arguments.length-1] | ||
| const script = document.createElement('script') | ||
| script.innerHTML = 'document.documentElement.classList.add("deque-axe-is-ready");' |
There was a problem hiding this comment.
Lets make sure this can continue to work on IE:
Suggested change
| const callback = arguments[arguments.length-1] | |
| const script = document.createElement('script') | |
| script.innerHTML = 'document.documentElement.classList.add("deque-axe-is-ready");' | |
| var callback = arguments[arguments.length-1] | |
| var script = document.createElement('script') | |
| script.innerHTML = 'document.documentElement.classList.add("deque-axe-is-ready");' |
There was a problem hiding this comment.
The CLI program relies on @axe-core/webdriverjs, which uses Array#from, global.Promise, "arrow functions" and other JS features that do not work in IE. I do not think this change is necessary, since this program doesn't work in IE to begin with.
stephenmathieson
changed the title
executeAsyncScript instead of functionpkg
stephenmathieson
previously requested changes
Jul 10, 2020
There was a problem hiding this comment.
Just like #49, please add comments and link to the relevant issue.
michael-siek
dismissed stale reviews from stephenmathieson and WilcoFiers
resolved
Co-authored-by: Stephen Mathieson <me@stephenmathieson.com>
stephenmathieson
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://github.com/dequelabs/axe-devtools-npm/issues/715
Reviewer checks
Required fields, to be filled out by PR reviewer(s)