Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): Enable program to work with pkg #48

Merged
merged 6 commits into from
Jul 14, 2020
Merged

fix(cli): Enable program to work with pkg #48

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b98c156
fix(cli): pass in string into `executeAsyncScript` instead of function
michael-siek Jul 9, 2020
54e80ca
add comment to function#toString
michael-siek Jul 13, 2020
c5bf578
Update packages/cli/lib/axe-test-urls.js
michael-siek Jul 13, 2020
7f4b21d
Merge branch 'develop' into fix-async-script
michael-siek Jul 13, 2020
bb7856d
Merge branch 'develop' into fix-async-script
michael-siek Jul 13, 2020
155fd4e
Merge branch 'develop' into fix-async-script
michael-siek Jul 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions packages/cli/lib/axe-test-urls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,15 @@ function testPages(urls, config, events) {
driver
.get(currentUrl)
.then(function () {
// Wait for the page to be loaded
return driver.executeAsyncScript(function (callback) {
// https://github.com/vercel/pkg/issues/676
// we need to pass a string vs a function so we manually stringified the function
return driver.executeAsyncScript(`
const callback = arguments[arguments.length - 1];
const script = document.createElement('script');
script.innerHTML =
'document.documentElement.classList.add("deque-axe-is-ready");';
script.innerHTML = 'document.documentElement.classList.add("deque-axe-is-ready");'
document.documentElement.appendChild(script);
callback();
});
`);
})
.then(function () {
return driver.wait(
Expand Down