Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support WDIO v8 #708

Merged
merged 4 commits into from
Apr 17, 2023
Merged

feat: support WDIO v8 #708

merged 4 commits into from
Apr 17, 2023

Conversation

michael-siek
Copy link
Member

@michael-siek michael-siek commented Apr 14, 2023 •
edited by straker
Loading

Closes: #695
Closes: #705

@michael-siek michael-siek requested a review from a team as a code owner April 14, 2023 13:04
@michael-siek michael-siek changed the title !feat: support WDIO v8 feat: support WDIO v8 Apr 14, 2023
Zidious
Zidious reviewed Apr 14, 2023
View reviewed changes
Copy link
Contributor

@Zidious Zidious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a question inline -

packages/webdriverio/src/index.ts Outdated Show resolved Hide resolved
@straker
Copy link
Contributor

straker commented Apr 17, 2023

We need to test this change in WDIO <8 to make sure there are no breaking changes for users (especially in typescript)

straker
straker approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@straker straker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Michael confirmed this works in TS, node 14, and WDIO v7 from a user importing our code so we shouldn't have any backwards compatibility issues with typescript.

@michael-siek michael-siek merged commit 1e40ec0 into develop Apr 17, 2023
@michael-siek michael-siek deleted the feat/support/wdio8 branch April 17, 2023 16:38
@dequejenn dequejenn mentioned this pull request May 1, 2023
Merged
@stephenmathieson stephenmathieson mentioned this pull request Jul 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straker straker straker approved these changes

@Zidious Zidious Awaiting requested review from Zidious

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@axe-core/webdriverio expects object but get's proxy object remove @wdio/sync
3 participants
@michael-siek @straker @Zidious