ci: Replace CircleCI with GitHub Actions #759
Conversation
…🐉🇬🇱🇸🇭🔣🧢🚀💖🧧🇬🇵🎹🔁🟦📆🦊👘🚋🌶️👓💈🥸⚕️5️⃣🇻🇮🇫🇯🗿☃️🧑⚕️🥈🎉🇹🇬🤼♂️✔️🇹🇹🗺️🤺
🇧🇷🇱🇧👨🚀🇮🇹♒🌝🐲🛎️🍬🤞👙📶📕🇮🇱⚧️🤐#️⃣🈯🪂
…🏌️♀️👉👸🏕️👬📤🙇♀️🧇🛠️🏋️♀️📨🟫⏩😶🌫️🛶🐳🥵👠⌚🇵🇭📐🪤⚓🔝🏥🚦👩❤️💋👨👨🔧🚤✂️💡🙌🧗👩🦯🇮🇨👩👩👧👦🈴🧚♂️😡⛹️♀️🇪🇨🤦🧦🙆♀️🌴🪵🙇♂️🧆☮️🇮🇱🔡👰🇲🇷👼
👨👨👦👦☎️👜⛵💁📍🤹🇦🇷🔻🌑☂️🎐……🗯️🈷️✊🥣🫑🐢😃🥟🇵🇳🥕🍊🚬👒🦁🇲🇳⚙️🇹🇨🏨🥷🖼️⏳🔔🤧🆚📪#️⃣⛽🇹🇱🆖💬⚕️🤛👨👨👧🔽🧤⬇️🤽♀️🐈⬛💵🛎️🥡🆖🍈🇹🇰😰🥧💩🪆🪚🦜🧦⌨️😐🌌🇷🇸
stephenmathieson
changed the title
| with: | ||
| node-version: ${{ matrix.node }} | ||
| cache: 'npm' | ||
| - run: npx playwright install --with-deps |
There was a problem hiding this comment.
If this job is a long-pole, we might consider running it on a playwright docker image pinned to the same version as our playwright version instead of ubuntu-latest - they come with playwright deps + matching browser versions pre-installed
There was a problem hiding this comment.
Good idea! This job does take significantly longer than similar jobs.
Are you OK with leaving this as-is and using the Playwright Docker image in a followup PR? I can likely get to it within the next few days.
| path: '**/node_modules' | ||
| key: ${{ runner.os }}-npm-${{ hashFiles('**/package-lock.json') }} | ||
| # Make sure the working tree is clean | ||
| - run: git reset --hard HEAD |
There was a problem hiding this comment.
Was this here previously for some reason that was specific to circleci? This feels like something that should be a "fail the build if not true" step, not a "silently force it to be true" step
There was a problem hiding this comment.
I do not know why this was here previously.
Also test Node.js versions 16, 18 and 20.