Skip to content

Conversation

@scottmries
Copy link
Contributor

If AxeBuilder is instantiated many times, each instance of the class will store the 250kb axe source string causing performance issues.

I looked at @axe-core/puppeteer and they follow the pattern in this PR:

No QA required

@scottmries scottmries requested a review from a team as a code owner March 4, 2025 20:48
@scottmries scottmries enabled auto-merge (squash) March 4, 2025 20:53
@scottmries scottmries merged commit e53cd36 into develop Mar 4, 2025
30 checks passed
@scottmries scottmries deleted the bensenescu-fork branch March 4, 2025 20:54
@github-actions github-actions bot mentioned this pull request Apr 28, 2025
@github-actions github-actions bot mentioned this pull request May 12, 2025
scottmries added a commit that referenced this pull request May 12, 2025
##
[4.10.2](v4.10.1...v4.10.2)
(2025-05-12)


### Bug Fixes

* Optimize AxeBuilder memory usage.
([#1154](#1154))
([e53cd36](e53cd36)),
closes
[/github.com/bensenescu/axe-core-npm/blob/develop/packages/puppeteer/src/axePuppeteer.ts#L59](https://github.com//github.com/bensenescu/axe-core-npm/blob/develop/packages/puppeteer/src/axePuppeteer.ts/issues/L59)
[/github.com/bensenescu/axe-core-npm/blob/develop/packages/puppeteer/src/utils.ts#L34](https://github.com//github.com/bensenescu/axe-core-npm/blob/develop/packages/puppeteer/src/utils.ts/issues/L34)
* Update axe-core to v4.10.3
([#1155](#1155))
([f8e3a14](f8e3a14))
* **wdio:** resolve blank navigation issue in WDIO v9
([#1169](#1169))
([6505560](6505560))

---------

Co-authored-by: Michael <me@michaelsiek.com>
Co-authored-by: Ben Allen <157512320+ballendq@users.noreply.github.com>
Co-authored-by: Gabe <41127686+Zidious@users.noreply.github.com>
Co-authored-by: Scott Ries <scott.ries@deque.com>
Co-authored-by: Ben Senescu <bensenescu@gmail.com>
Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
Co-authored-by: attest-team-ci <48030122+attest-team-ci@users.noreply.github.com>
Co-authored-by: Zidious <Zidious@users.noreply.github.com>
Co-authored-by: Siarhei_Kliushnikau <siarhei_kliushnikau@epam.com>
Co-authored-by: usama <76848490+usamaJ17@users.noreply.github.com>
Co-authored-by: API Team CI User <aciattestteamci@deque.com>
scottmries added a commit that referenced this pull request May 16, 2025
##
[4.10.2](v4.10.1...v4.10.2)
(2025-04-28)


### Bug Fixes

* Optimize AxeBuilder memory usage.
([#1154](#1154))
([e53cd36](e53cd36)),
closes
[/github.com/bensenescu/axe-core-npm/blob/develop/packages/puppeteer/src/axePuppeteer.ts#L59](https://github.com//github.com/bensenescu/axe-core-npm/blob/develop/packages/puppeteer/src/axePuppeteer.ts/issues/L59)
[/github.com/bensenescu/axe-core-npm/blob/develop/packages/puppeteer/src/utils.ts#L34](https://github.com//github.com/bensenescu/axe-core-npm/blob/develop/packages/puppeteer/src/utils.ts/issues/L34)
* Update axe-core to v4.10.3
([#1155](#1155))
([f8e3a14](f8e3a14))
* **wdio:** resolve blank navigation issue in WDIO v9
([#1169](#1169))
([6505560](6505560))

No qa required
@github-actions github-actions bot mentioned this pull request Oct 14, 2025
straker added a commit that referenced this pull request Oct 16, 2025
#
[4.11.0](v4.10.1...v4.11.0)
(2025-10-14)


### Bug Fixes

* Optimize AxeBuilder memory usage.
([#1154](#1154))
([e53cd36](e53cd36)),
closes
[/github.com/bensenescu/axe-core-npm/blob/develop/packages/puppeteer/src/axePuppeteer.ts#L59](https://github.com//github.com/bensenescu/axe-core-npm/blob/develop/packages/puppeteer/src/axePuppeteer.ts/issues/L59)
[/github.com/bensenescu/axe-core-npm/blob/develop/packages/puppeteer/src/utils.ts#L34](https://github.com//github.com/bensenescu/axe-core-npm/blob/develop/packages/puppeteer/src/utils.ts/issues/L34)
* Update axe-core to v4.10.3
([#1155](#1155))
([f8e3a14](f8e3a14))
* **wdio:** resolve blank navigation issue in WDIO v9
([#1169](#1169))
([6505560](6505560))


### Features

* Update axe-core to v4.11.0
([#1233](#1233))
([2758476](2758476))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants