Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(puppeteer,playwright): wait for finishRun to complete before closing the page #496

Merged
merged 5 commits into from
Apr 4, 2022
Merged

fix(puppeteer,playwright): wait for finishRun to complete before closing the page #496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
509b9f0
fix(playwright): Await page close
jpveooys Mar 25, 2022
554470a
fix(puppeteer): Await page close
jpveooys Mar 25, 2022
cc8ed53
add verbose to BRM
Zidious Apr 4, 2022
5517ed2
update config.yml CI
Zidious Apr 4, 2022
45e1791
add lerna link after chromedriver installation
Zidious Apr 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,9 @@ jobs:
- restore_dependency_cache
# Re-build packages, ensuring packages/webdriverjs/dist exists.
- run: npx lerna run prepare
- run: npx browser-driver-manager@1.0.4 install chrome chromedriver
- run: cd packages/cli && npx browser-driver-manager@1.0.4 install chrome chromedriver --verbose
# lerna link after installing the latest version of chromedriver, as we depend on webdriverJS
- run: cd packages/cli && npx lerna link
- run: npm run coverage --prefix=packages/cli

puppeteer:
Expand All @@ -143,15 +145,15 @@ jobs:
- checkout
- restore_dependency_cache
- run: npm run build --prefix=packages/puppeteer
- run: npx browser-driver-manager@1.0.4 install chrome chromedriver
- run: cd packages/puppeteer && npx browser-driver-manager@1.0.4 install chrome chromedriver --verbose
- run: npm run coverage --prefix=packages/puppeteer

webdriverjs:
<<: *defaults
steps:
- checkout
- restore_dependency_cache
- run: npx browser-driver-manager@1.0.4 install chrome chromedriver
- run: cd packages/webdriverjs && npx browser-driver-manager@1.0.4 install chrome chromedriver --verbose
- run: npm --prefix=packages/webdriverjs run build
- run: npm run coverage --prefix=packages/webdriverjs

Expand All @@ -170,7 +172,7 @@ jobs:
steps:
- checkout
- restore_dependency_cache
- run: npx browser-driver-manager@1.0.4 install chrome chromedriver
- run: cd packages/webdriverio && npx browser-driver-manager@1.0.4 install chrome chromedriver --verbose
- run: npm run coverage --prefix=packages/webdriverio

reporter-earl:
Expand Down
4 changes: 2 additions & 2 deletions packages/playwright/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,8 +290,8 @@ export default class AxeBuilder {
partialResults,
options
})
.finally(() => {
blankPage.close();
.finally(async () => {
await blankPage.close();
});
}
}
4 changes: 2 additions & 2 deletions packages/puppeteer/src/axePuppeteer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,8 +280,8 @@ export class AxePuppeteer {
partialResults as JSONArray,
axeOptions as JSONObject
)
.finally(() => {
blankPage.close();
.finally(async () => {
await blankPage.close();
});
}

Expand Down