Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): replace axe-webdriverjs in favor of @axe-core/webdriverjs #51

Merged
merged 7 commits into from
Jul 14, 2020
Merged

feat(cli): replace axe-webdriverjs in favor of @axe-core/webdriverjs #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d62ac24
feat(cli): replace axe-webdriverjs in favor of @axe-core/webdriverjs
michael-siek Jul 14, 2020
980ebd9
lerna stuff
michael-siek Jul 14, 2020
1df89bc
add prepare script
michael-siek Jul 14, 2020
93aad6f
regenerate package lock file
michael-siek Jul 14, 2020
2b6bbf3
ci fix?
michael-siek Jul 14, 2020
63ae07c
remove agora
michael-siek Jul 14, 2020
4f4f8c5
Run `prepare` and only do `--ci` in CI
stephenmathieson Jul 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
key: v1-root-npm-{{ checksum "package-lock.json" }}
paths:
- node_modules
- run: npm run bootstrap
- run: npm run bootstrap -- --ci
- save_cache:
key: v1-cli-npm-{{ checksum "packages/cli/package-lock.json" }}
paths:
Expand Down Expand Up @@ -90,6 +90,8 @@ jobs:
steps:
- checkout
- restore_dependency_cache
# Re-build packages, ensuring packages/webdriverjs/dist exists.
- run: npx lerna run prepare
- run: npm run test --prefix=packages/cli

puppeteer:
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ After installing, you can now run the `axe` command in your CLI, followed by the
axe https://www.deque.com
```

You can run multiple pages at once, simply add more URLs to the command. Keep in mind that axe-cli is not a crawler, so if you find yourself testing dozens of pages at once, you may want to consider switching over to something like [axe-webdriverjs](https://www.npmjs.com/package/axe-webdriverjs). If you do not specify the protocol, http will be used by default:
You can run multiple pages at once, simply add more URLs to the command. Keep in mind that axe-cli is not a crawler, so if you find yourself testing dozens of pages at once, you may want to consider switching over to something like [@axe-core/webdriverjs](https://www.npmjs.com/package/@axe-core/webdriverjs). If you do not specify the protocol, http will be used by default:

```
axe www.deque.com, dequeuniversity.com
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/lib/axe-test-urls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';

const WebDriver = require('selenium-webdriver');
const AxeBuilder = require('axe-webdriverjs');
const AxeBuilder = require('@axe-core/webdriverjs');

function testPages(urls, config, events) {
const driver = config.driver;
Expand Down
483 changes: 241 additions & 242 deletions packages/cli/package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@
"url": "http://github.com/wilcofiers/"
},
"dependencies": {
"@axe-core/webdriverjs": "4.0.0-pre.0",
"axe-core": "^3.2.2",
"axe-webdriverjs": "^2.2.0",
"chromedriver": "latest",
"colors": "^1.4.0",
"commander": "^2.19.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/webdriverjs/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/webdriverjs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"test:sauce": "mocha test/sauce/*.js --require babel-register",
"coverage": "nyc npm run test:unit",
"build": "babel lib --out-dir dist",
"prepublishOnly": "npm run build"
"prepare": "npm run build"
},
"peerDependencies": {
"selenium-webdriver": ">= 2.53.1"
Expand Down