fix(puppeteer): support puppeteer v15 #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-siek
commented
Jun 24, 2022
| @@ -61,7 +61,7 @@ function injectJSSource( | |||
| source: string | Function, | |||
| args: any[] = [] | |||
| ): Promise<void> { | |||
| return frame.evaluate(source as any, ...args); | |||
| return frame.evaluate(source as any, ...args) as Promise<void>; | |||
There was a problem hiding this comment.
Needed to typecast since this was type Promise<unknown>
There was a problem hiding this comment.
I should not review this, as I've made changes here.
IMO this should show up in release notes, either as a bug fix or a feature.
We should always look for alternatives to hacking tsconfig. By using the actual Puppeteer types, we can avoid all of the hacks/casts and just pass plain objects around.
michael-siek
changed the title
straker
approved these changes
Jun 27, 2022
|
Did some quick testing using puppeteer v12-15. All ran without issues (including with typescript). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #534