-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): improve error message on script timeout #681
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you like these changes please merge them without squashing.
We squash all PRs. If you want to make multiple unrelated changes, open multiple unrelated PRs.
26ed62a
to
b82fd9a
Compare
I think there are certain cases where it makes sense to make an exception (e.g. larger refactors). In this case though it was easy for me to split off the other change into #683. (sidenote: the current dependencies CI failure does not appear to be related to the changes I made) |
Hey @not-my-profile, Apologies for the delay, once we get CI running on your PR we'll be able to merge it in. Thanks again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the contribution.
Reviewed for security.
Previously a script timeout error just displayed a stack trace without any information on the current timeout or how to change the timeout.