fix(cli): do not inject script tags due to pages not allowing script tags #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zidious
previously approved these changes
Apr 18, 2023
The title should also describe the purpose of the commit, not how the commit does it. Refer to the SDLC |
michael-siek
changed the title
Zidious
approved these changes
Apr 19, 2023
| @@ -78,7 +78,7 @@ | |||
| ], | |||
| "statements": 95, | |||
| "branches": 92, | |||
| "functions": 100, | |||
| "functions": 94, | |||
There was a problem hiding this comment.
nit - This is still above the required coverage, but maintain or increase coverage IMO
There was a problem hiding this comment.
How is coverage dropping by removing code? 🤔
There was a problem hiding this comment.
I also removed test but those test only tested the thing that I removed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #711