chore: Make existing ESLint warnings fail the build #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
People don't care about warnings. Unless a build fails, ESLint output will go unnoticed. This patch prevents that from happening by converting existing warnings to errors. Also all existing warnings have been fixed.
straker
reviewed
Jul 10, 2023
| @@ -152,6 +152,8 @@ export const axeRunPartial = ( | |||
| export const axeGetFrameContext = ( | |||
| client: Browser, | |||
| context: SerialContextObject | |||
| // TODO: add proper types | |||
There was a problem hiding this comment.
Was this left in intentionally?
straker
approved these changes
Jul 10, 2023
This was referenced Jul 26, 2023
This was referenced Aug 24, 2023
This was referenced Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People don't care about warnings. Unless a build fails, ESLint output will go unnoticed. This patch prevents that from happening by converting existing warnings to errors.
Also all existing warnings have been fixed.