Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix GH release workflow #877

Merged
merged 3 commits into from
Oct 24, 2023
Merged

ci: fix GH release workflow #877

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
87bb34f
ci: fix GH release
michael-siek Oct 13, 2023
cefa367
Update deploy.yml
michael-siek Oct 16, 2023
aea08d5
Update .github/workflows/deploy.yml
michael-siek Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,4 +53,9 @@ jobs:
npx lerna publish from-package \
--force-publish='*' \
--yes
- uses: softprops/action-gh-release@de2c0eb89ae2a093876385947365aca7b0e5f844 # v0.1.15
- run: |
PKG_VERSION=$(jq -r .version < lerna.json)
gh release create v$PKG_VERSION \
--title "Release v$PKG_VERSION" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our github releases do not use the v syntax for releases. Not sure we want to move to doing that now

--generate-notes \
--repo ${{ github.repository }}