Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webdriverio): work with @wdio/globals #882

Merged
merged 5 commits into from
Oct 24, 2023
Merged

Conversation

straker
Copy link
Contributor

@straker straker commented Oct 20, 2023

When using @wdio/globals, browser is a function and not an object (thanks wdio).

Closes: #798

@straker straker requested a review from a team as a code owner October 20, 2023 17:33
Copy link
Contributor

@Zidious Zidious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment about test-listen otherwise LGTM

test/wdio/wdio-globals.spec.ts Show resolved Hide resolved
test/wdio/wdio-globals.spec.ts Outdated Show resolved Hide resolved
packages/webdriverio/src/utils.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@Zidious Zidious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@straker straker merged commit 2e016b4 into develop Oct 24, 2023
29 checks passed
@straker straker deleted the fix-wdio-globals branch October 24, 2023 17:39
@github-actions github-actions bot mentioned this pull request Nov 30, 2023
@dequejenn dequejenn mentioned this pull request Dec 5, 2023
@github-actions github-actions bot mentioned this pull request Jan 9, 2024
@github-actions github-actions bot mentioned this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error occurs when WebdriverIO version is higher than 5
2 participants