-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: test built types export #945
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
// This file isn't executed; we only care that typescript can successfully | ||
// build/typecheck. It is a smoke test that our build process is producing a | ||
// basically-reasonable index.d.ts. | ||
|
||
// Detailed tests of individual types should instead be covered by unit tests. | ||
|
||
import { AxeBuilder as NamedImportAxeBuilder } from '../dist/index.js'; | ||
import DefaultImportAxeBuilder from '../dist/index.js'; | ||
import type { Page } from 'playwright-core'; | ||
|
||
// See https://stackoverflow.com/a/55541672 | ||
type IsAny<T> = 0 extends 1 & T ? true : false; | ||
|
||
// If the imports don't have typings assigned, these will fail | ||
// with "ts(2322): Type 'false' is not assignable to type 'true'." | ||
(x: IsAny<typeof NamedImportAxeBuilder>): false => x; | ||
(x: IsAny<typeof DefaultImportAxeBuilder>): false => x; | ||
|
||
new NamedImportAxeBuilder({ page: {} as Page }).withRules('label').analyze(); | ||
|
||
new DefaultImportAxeBuilder({ page: {} as Page }).withRules('label').analyze(); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
// This file isn't executed; we only care that typescript can successfully | ||
// build/typecheck. It is a smoke test that our build process is producing a | ||
// basically-reasonable index.d.ts. | ||
|
||
// Detailed tests of individual types should instead be covered by unit tests. | ||
|
||
import { AxePuppeteer as NamedImportAxeBuilder } from '../dist/index.js'; | ||
import DefaultImportAxeBuilder from '../dist/index.js'; | ||
import type { Page } from 'puppeteer'; | ||
|
||
// See https://stackoverflow.com/a/55541672 | ||
type IsAny<T> = 0 extends 1 & T ? true : false; | ||
|
||
// If the imports don't have typings assigned, these will fail | ||
// with "ts(2322): Type 'false' is not assignable to type 'true'." | ||
(x: IsAny<typeof NamedImportAxeBuilder>): false => x; | ||
(x: IsAny<typeof DefaultImportAxeBuilder>): false => x; | ||
|
||
new NamedImportAxeBuilder({} as Page).withRules('label').analyze(); | ||
|
||
new DefaultImportAxeBuilder({} as Page).withRules('label').analyze(); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
// This file isn't executed; we only care that typescript can successfully | ||
// build/typecheck. It is a smoke test that our build process is producing a | ||
// basically-reasonable index.d.ts. | ||
|
||
// Detailed tests of individual types should instead be covered by unit tests. | ||
|
||
import reactAxe from '../dist/index.js'; | ||
import React from 'react'; | ||
import ReactDOM from 'react-dom'; | ||
|
||
// See https://stackoverflow.com/a/55541672 | ||
type IsAny<T> = 0 extends 1 & T ? true : false; | ||
|
||
// If the imports don't have typings assigned, these will fail | ||
// with "ts(2322): Type 'false' is not assignable to type 'true'." | ||
(x: IsAny<typeof reactAxe>): false => x; | ||
|
||
reactAxe(React, ReactDOM, 1000); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
// This file isn't executed; we only care that typescript can successfully | ||
// build/typecheck. It is a smoke test that our build process is producing a | ||
// basically-reasonable index.d.ts. | ||
|
||
// Detailed tests of individual types should instead be covered by unit tests. | ||
|
||
import DefaultImportReporter from '../dist/axeReporterEarl.js'; | ||
// import axe from 'axe-core'; | ||
|
||
// See https://stackoverflow.com/a/55541672 | ||
type IsAny<T> = 0 extends 1 & T ? true : false; | ||
|
||
// If the imports don't have typings assigned, these will fail | ||
// with "ts(2322): Type 'false' is not assignable to type 'true'." | ||
(x: IsAny<typeof DefaultImportReporter>): false => x; | ||
|
||
// TODO: this doesn't work as our types are broken | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See #944 |
||
// axe.configure({ reporter: DefaultImportReporter }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
// This file isn't executed; we only care that typescript can successfully | ||
// build/typecheck. It is a smoke test that our build process is producing a | ||
// basically-reasonable index.d.ts. | ||
|
||
// Detailed tests of individual types should instead be covered by unit tests. | ||
|
||
import { AxeBuilder as NamedImportAxeBuilder } from '../dist/index.js'; | ||
import DefaultImportAxeBuilder from '../dist/index.js'; | ||
import type { Browser } from 'webdriverio'; | ||
|
||
// See https://stackoverflow.com/a/55541672 | ||
type IsAny<T> = 0 extends 1 & T ? true : false; | ||
|
||
// If the imports don't have typings assigned, these will fail | ||
// with "ts(2322): Type 'false' is not assignable to type 'true'." | ||
(x: IsAny<typeof NamedImportAxeBuilder>): false => x; | ||
(x: IsAny<typeof DefaultImportAxeBuilder>): false => x; | ||
|
||
new NamedImportAxeBuilder({ client: {} as Browser }) | ||
.withRules('label') | ||
.analyze(); | ||
|
||
new DefaultImportAxeBuilder({ client: {} as Browser }) | ||
.withRules('label') | ||
.analyze(); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
// This file isn't executed; we only care that typescript can successfully | ||
// build/typecheck. It is a smoke test that our build process is producing a | ||
// basically-reasonable index.d.ts. | ||
|
||
// Detailed tests of individual types should instead be covered by unit tests. | ||
|
||
import { AxeBuilder as NamedImportAxeBuilder } from '../dist/index.js'; | ||
import DefaultImportAxeBuilder from '../dist/index.js'; | ||
import type { WebDriver } from 'selenium-webdriver'; | ||
|
||
// See https://stackoverflow.com/a/55541672 | ||
type IsAny<T> = 0 extends 1 & T ? true : false; | ||
|
||
// If the imports don't have typings assigned, these will fail | ||
// with "ts(2322): Type 'false' is not assignable to type 'true'." | ||
(x: IsAny<typeof NamedImportAxeBuilder>): false => x; | ||
(x: IsAny<typeof DefaultImportAxeBuilder>): false => x; | ||
|
||
new NamedImportAxeBuilder({} as WebDriver).withRules('label').analyze(); | ||
|
||
new DefaultImportAxeBuilder({} as WebDriver).withRules('label').analyze(); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could probably do it like this too. Two imports on the same file is a little odd.