fix(webdriverjs): use new headless argument to fix selenium-webdriver@4.17.0 breaking release #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…@4.17.0 breaking release
dbjorge
approved these changes
Jan 23, 2024
Merged
Closed
This was referenced Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selenium-webdriver@4.17.0 released a breaking change that removed the deprecated function to call
setHeadlessorheadless. Fixed by using the newaddArugmentswith--headless, and feature detecting the function before calling it in order to support older versions of selenium.Also patched pin to selenium-webdriver as they do not follow semver and can release breaking changes in minor versions.
Closes: #991