feat: replace AxeResult.Error property with exceptions #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbjorge
changed the title
AxeResult.Error property with exceptions
lisli1
reviewed
Oct 11, 2022
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR removes the
AxeResult.Errorproperty that was previously used to indicate a very select few types of errors (exceptions emitted from runLegacy.js or finishRun.js, but only against WebDrivers that didn't normalize those errors as JavaScriptExceptions already) and replaces it with exception-throwing. From a user's perspective, this means that if a scan emits an exception (should be rare anyway), it will propagate as a test failure instead of (probably) ending up silently ignored.I also added a basic
AxeResultunit test as part of writing a test for the new functionality. While writing basic unit tests I noticed that the defaultToStringbehaviorAxeResultis currently using is pretty user-unfriendly, but I felt that should be addressed in a separate PR, so I omitted that test/update from this one.Tests are part of: #22