Add tests for aria-empty-table-header rule

dequelabs · Feb 21, 2021 · 7fd95fd · 7fd95fd
1 parent bb7c671
commit 7fd95fd
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 9 deletions.
diff --git a/lib/rules/aria-empty-table-header.json b/lib/rules/aria-empty-table-header.json
@@ -1,12 +1,13 @@
 {
 	"id": "aria-empty-table-header",
 	"selector": "th, [role=\"rowheader\"], [role=\"columnheader\"]",
+	"matches": "heading-matches",
 	"tags": ["wcag131"],
 	"metadata": {
 		"description": "Ensures table headers have discernible text",
 		"help": "Table header text must not be empty"
 	},
-	"all": ["has-accessible-text"],
-	"any": [],
+	"all": [],
+	"any": ["has-accessible-text"],
 	"none": []
 }
diff --git a/test/integration/rules/aria-empty-table-header/aria-empty-table-header.html b/test/integration/rules/aria-empty-table-header/aria-empty-table-header.html
@@ -1 +1,21 @@
-<!-- HTML Snippets-->
+<!DOCTYPE html>
+<html lang="en">
+	<head>
+		<title>empty-table-header test</title>
+		<meta charset="utf8" />
+		<script src="/axe.js"></script>
+	</head>
+
+	<body>
+		<th id="pass1">Ok</th>
+		<td id="pass2" role="rowheader">rowheader with name</td>
+		<td id="pass3" role="columnheader">columnheader with name</td>
+		<th id="fail1"></th>
+		<td id="fail2" role="rowheader">
+			<div style="display: none">Not Ok</div>
+		</td>
+		<td id="fail3" role="columnheader">
+			<div style="display: none">Not Ok</div>
+		</td>
+	</body>
+</html>
diff --git a/test/integration/rules/aria-empty-table-header/aria-empty-table-header.json b/test/integration/rules/aria-empty-table-header/aria-empty-table-header.json
@@ -1,6 +1,6 @@
 {
 	"description": "aria-empty-table-header tests",
 	"rule": "aria-empty-table-header",
-	"violations": [],
-	"passes": []
+	"violations": [["fail1"], ["fail2"], ["fail3"]],
+	"passes": [["#pass1"], ["#pass2"], ["#pass3"]]
 }
diff --git a/test/rule-matches/aria-empty-table-header-matches.js b/test/rule-matches/aria-empty-table-header-matches.js