Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(audit): add lang query paramenter to help urls #1794

Merged
merged 3 commits into from
Sep 5, 2019
Merged

feat(audit): add lang query paramenter to help urls #1794

merged 3 commits into from
Sep 5, 2019

Conversation

straker
Copy link
Contributor

@straker straker commented Aug 29, 2019 •
edited by WilcoFiers
Loading

Closes issue: #1784

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner August 29, 2019 21:00
@straker
Copy link
Contributor Author

straker commented Aug 29, 2019 •
edited
Loading

As a side note, I noticed that a lot of the functions in audit don't have any tests. For example, the entire applyLocale flow doesn't have any specific tests.

WilcoFiers
WilcoFiers previously requested changes Aug 30, 2019
View reviewed changes
lib/core/base/audit.js Outdated Show resolved Hide resolved
test/core/base/audit.js Show resolved Hide resolved
@straker straker merged commit 2d1c8a6 into develop Sep 5, 2019
@straker straker deleted the helpUrlsWithlang branch September 5, 2019 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@straker @WilcoFiers