Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rule aria-required-children #2076

Closed
jeeyyy opened this issue Mar 2, 2020 · 2 comments
Closed

Update rule aria-required-children #2076

jeeyyy opened this issue Mar 2, 2020 · 2 comments
Assignees

Comments

@jeeyyy
Copy link
Contributor

jeeyyy commented Mar 2, 2020

Expectation:
For examples below, the rule should fail because required children role is not correct.

<div role="list">
	<div role="tabpanel">
		<div role="listitem">List item 1</div>
	</div>
</div>
<div role="list" aria-owns="item"></div>

<div id="host"></div>

<script>
	const host = document.querySelector('#host')
	const root = host.attachShadow({ mode: 'open' })
	root.innerHTML = '<div id="item" role="listitem">List item 1</div>'
</script>

Actual:
The rule only looks for children with an allowed role, without intercepting nodes in between which can have over-ridding roles.

Motivation:
Required for implementation of rule in ACT Rule - https://act-rules.github.io/rules/bc4a75

@padmavemulapati
Copy link

Verified with latest axe-core, and with the above specified test example, aria-required-children rule is failing , which is expected.
image

@straker
Copy link
Contributor

straker commented Apr 30, 2020

No docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants