Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background videos: false positive for videos needing caption tracks #249

Closed
mfairchild365 opened this issue Nov 2, 2016 · 2 comments
Closed

Comments

@mfairchild365
Copy link
Contributor

mfairchild365 commented Nov 2, 2016

Background videos (videos that are played in the background with no audio, usually with other content over it) are becomming more and more common. They also pose a problem for accessibility. For a reference on the issue see this great article: http://www.punkchip.com/accessible-html-video-as-a-background/

Right now axe will flag these videos as missing a captions track and description track.

I'm trying to think of some ways to improve that check. I've thought of the following:

  1. check if the video is marked up as an image (role=img). See my thoughts at: https://gist.github.com/mfairchild365/2dbffbcac3286413c0509ea8e8e7ad7c However, this isn't a standard (and maybe not even the best way) to mark up these kinds of videos.
  2. check for the presence of an audio track. Something along the lines of http://stackoverflow.com/questions/21270048/html5-video-how-to-detect-when-there-is-no-audio-track#answer-31022391 However, how would you account for background videos that have an audio track but it is just muted? Check for both of those conditions?
@WilcoFiers
Copy link
Contributor

I like the idea of checking for the audio. I'm not too sure about the role=img though. That's not a common design pattern as far as I know, so I would say the chance of someone using that the way you intend it isn't likely, unless they are specifically trying to pass axe.

@marcysutton
Copy link
Contributor

I think our Needs Review workflow will make this better, since the user will get a chance to review it and decide if it's a violation. Therefore I'm going to close this as a duplicate of #285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants