Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive for captioned <video> without <track> #285

Closed
jasonkiss opened this issue Feb 12, 2017 · 7 comments
Closed

False positive for captioned <video> without <track> #285

jasonkiss opened this issue Feb 12, 2017 · 7 comments

Comments

@jasonkiss
Copy link

The "

@marcysutton
Copy link
Contributor

marcysutton commented Feb 14, 2017

Thanks for your issue @jasonkiss. It does look like Youtube captions are added in a random DIV element, a la:

<div class="caption-window ytp-caption-window-bottom ytp-caption-window-rollup"
id="caption-window-1" dir="ltr" tabindex="0" aria-live="assertive" lang="en" 
draggable="true" data-layer="5" 
style="touch-action: none; text-align: left; left: 60.8369%; width: 508px; height: 38px; margin-left: -254px; bottom: 12.207%;">
<span class="captions-text"></span></div>

The <track> element would be a more standards-focused application, but IMO captions used in this manner or embedded in a video are just as usable by people. Perhaps we should move this to a Best Practice rule instead @dylanb @WilcoFiers? Since there aren't reliable ways to check for custom caption DIVs or captions embedded in videos.

@jasonkiss
Copy link
Author

WFM.

I wonder if there's a similar issue with audio description and the aXe rule for that?

@dylanb
Copy link
Contributor

dylanb commented Feb 14, 2017

Our plan is to move these rules to the "needs review" category once that lands in the aXe extensions

@marcysutton
Copy link
Contributor

Oh yes. That will be perfect!

@JaredNoble
Copy link

I can confirm that the audio element also generates the same result for a missing track tag.

@marcysutton
Copy link
Contributor

This has been fixed internally, and will be in our next release.

marcysutton pushed a commit that referenced this issue Apr 25, 2017
feat: change audio/video rule to report incomplete

Closes #285

Approved-by: Wilco Fiers <wilco.fiers@deque.com>
@marcysutton
Copy link
Contributor

Fixed with 30be884 . Stay tuned for a release of axe-core 2.2.0

mrtnvh pushed a commit to mrtnvh/axe-core that referenced this issue Nov 24, 2023
…rter-earl (dequelabs#285)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants