Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

summary[role='button'] without accessible name not reported #3444

Closed
khiga8 opened this issue Apr 28, 2022 · 3 comments · Fixed by #4528
Closed

summary[role='button'] without accessible name not reported #3444

khiga8 opened this issue Apr 28, 2022 · 3 comments · Fixed by #4528
Assignees
Labels
false negative feat New feature or enhancement pr A pr has been created for the issue
Milestone

Comments

@khiga8
Copy link

khiga8 commented Apr 28, 2022

Hello! We are upgrading our axe version from 4.0.0 to 4.4.1 (yes we are a bit behind).

Previously axe reported summary[role='button'] without an accessible name as a violation. However, since the upgrade, it is no longer reported. I notice there were some changes with some of the logic in button-name being moved into a new aria-command-name.

I believe any element with [role='button'] without an accessible name should be reported.

@straker
Copy link
Contributor

straker commented May 2, 2022

Thanks for the issue. I'm not exactly sure how to deal with this one as there seems to be a few things going on. I'll have to get with @WilcoFiers to see what he thinks.

@WilcoFiers
Copy link
Contributor

I'm very surprised axe doesn't cover is. That's an unusually large gap. I think the solve is to add it to the button-name rule. Lets make sure we do this for the next minor release.

@WilcoFiers WilcoFiers added this to the Axe-core 4.5 milestone May 4, 2022
@WilcoFiers WilcoFiers added the feat New feature or enhancement label May 4, 2022
@WilcoFiers WilcoFiers modified the milestones: Axe-core 4.5, Axe-core 4.6 May 20, 2022
@WilcoFiers WilcoFiers modified the milestones: Axe-core 4.7, Axe-core 4.8 Jan 19, 2023
@WilcoFiers WilcoFiers modified the milestones: Axe-core 4.8, Axe-core 4.9 Jun 29, 2023
@WilcoFiers WilcoFiers self-assigned this Jul 8, 2024
@WilcoFiers WilcoFiers added the pr A pr has been created for the issue label Jul 8, 2024
@padmavemulapati
Copy link

Verified with dev branch code base, for summary element if role=button is given, it should serve with the accessbile name. If role=button without an accessible name should be reported.

Test code snippet:

<details>
    <summary id="button-role-fail" role="button"></summary>
    Hello world
  </details>

image

Environment:

Label Value
Product axe-core
Version 4.10.0(Dev Branch Code base
OS-Details _MAC- 14.4.1 _
BrowserDetails Chrome Version 126.0.4

WilcoFiers added a commit that referenced this issue Jul 10, 2024
Closes: #3444

---------

Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
false negative feat New feature or enhancement pr A pr has been created for the issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants