Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

help-same-as-label check - Shadow DOM support #387

Closed
marcysutton opened this issue Jun 29, 2017 · 1 comment
Closed

help-same-as-label check - Shadow DOM support #387

marcysutton opened this issue Jun 29, 2017 · 1 comment
Assignees
@dylanb

Comments

@marcysutton
Copy link
Contributor

marcysutton commented Jun 29, 2017 •
edited
Loading

The help-same-as-label check needs to be updated for Shadow DOM. Here are the failing tests:

    8) should return true if an element has a label and a title with the same text
    9) should return true if an element has a label and aria-describedby with the same text
    10) should return false if input only has a title
    11) should return true if an input only has aria-describedby

Sub-task of #87.

Full stack trace:

8) help-same-as-label should return true if an element has a label and a title with the same text:
     
  label@http://localhost:9876/axe.js:8120:28
  label@http://localhost:9876/axe.js:9397:31
  evaluate@http://localhost:9876/tmp/rules.js:1328:42
  http://localhost:9876/test/checks/label/help-same-as-label.js:18:54
  callFn@http://localhost:9876/node_modules/mocha/mocha.js:4447:25
  run@http://localhost:9876/node_modules/mocha/mocha.js:4439:13
  runTest@http://localhost:9876/node_modules/mocha/mocha.js:4936:13
  http://localhost:9876/node_modules/mocha/mocha.js:5042:19
  next@http://localhost:9876/node_modules/mocha/mocha.js:4853:16
  http://localhost:9876/node_modules/mocha/mocha.js:4863:11
  next@http://localhost:9876/node_modules/mocha/mocha.js:4787:16
  http://localhost:9876/node_modules/mocha/mocha.js:4831:9
  timeslice@http://localhost:9876/node_modules/mocha/mocha.js:82:27

  9) help-same-as-label should return true if an element has a label and aria-describedby with the same text:
     
  label@http://localhost:9876/axe.js:8120:28
  label@http://localhost:9876/axe.js:9397:31
  evaluate@http://localhost:9876/tmp/rules.js:1328:42
  http://localhost:9876/test/checks/label/help-same-as-label.js:33:54
  callFn@http://localhost:9876/node_modules/mocha/mocha.js:4447:25
  run@http://localhost:9876/node_modules/mocha/mocha.js:4439:13
  runTest@http://localhost:9876/node_modules/mocha/mocha.js:4936:13
  http://localhost:9876/node_modules/mocha/mocha.js:5042:19
  next@http://localhost:9876/node_modules/mocha/mocha.js:4853:16
  http://localhost:9876/node_modules/mocha/mocha.js:4863:11
  next@http://localhost:9876/node_modules/mocha/mocha.js:4787:16
  http://localhost:9876/node_modules/mocha/mocha.js:4831:9
  timeslice@http://localhost:9876/node_modules/mocha/mocha.js:82:27

  10) help-same-as-label should return false if input only has a title:
     
  label@http://localhost:9876/axe.js:8120:28
  label@http://localhost:9876/axe.js:9397:31
  evaluate@http://localhost:9876/tmp/rules.js:1328:42
  http://localhost:9876/test/checks/label/help-same-as-label.js:44:55
  callFn@http://localhost:9876/node_modules/mocha/mocha.js:4447:25
  run@http://localhost:9876/node_modules/mocha/mocha.js:4439:13
  runTest@http://localhost:9876/node_modules/mocha/mocha.js:4936:13
  http://localhost:9876/node_modules/mocha/mocha.js:5042:19
  next@http://localhost:9876/node_modules/mocha/mocha.js:4853:16
  http://localhost:9876/node_modules/mocha/mocha.js:4863:11
  next@http://localhost:9876/node_modules/mocha/mocha.js:4787:16
  http://localhost:9876/node_modules/mocha/mocha.js:4831:9
  timeslice@http://localhost:9876/node_modules/mocha/mocha.js:82:27

  11) help-same-as-label should return true if an input only has aria-describedby:
     
  label@http://localhost:9876/axe.js:8120:28
  label@http://localhost:9876/axe.js:9397:31
  evaluate@http://localhost:9876/tmp/rules.js:1328:42
  http://localhost:9876/test/checks/label/help-same-as-label.js:59:55
  callFn@http://localhost:9876/node_modules/mocha/mocha.js:4447:25
  run@http://localhost:9876/node_modules/mocha/mocha.js:4439:13
  runTest@http://localhost:9876/node_modules/mocha/mocha.js:4936:13
  http://localhost:9876/node_modules/mocha/mocha.js:5042:19
  next@http://localhost:9876/node_modules/mocha/mocha.js:4853:16
  http://localhost:9876/node_modules/mocha/mocha.js:4863:11
  next@http://localhost:9876/node_modules/mocha/mocha.js:4787:16
  http://localhost:9876/node_modules/mocha/mocha.js:4831:9
  timeslice@http://localhost:9876/node_modules/mocha/mocha.js:82:27
@dylanb dylanb self-assigned this Jun 30, 2017
@dylanb dylanb mentioned this issue Jun 30, 2017
Merged
@marcysutton
Copy link
Contributor Author

Fixed with #400.

mrtnvh pushed a commit to mrtnvh/axe-core that referenced this issue Nov 24, 2023
@stephenmathieson
fix(webdriverjs): Reject with actual Errors (not strings) (dequelab…
3fdb50a 
…s#423)

Closes dequelabs#422
Ref dequelabs#421
Ref dequelabs#387
Ref dequelabs#308 (somewhat)
Ref dequelabs#207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dylanb dylanb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dylanb @marcysutton