Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give rules a consistent impact #4066

Closed
5 tasks done
WilcoFiers opened this issue Jun 28, 2023 · 0 comments · Fixed by #4114
Closed
5 tasks done

Give rules a consistent impact #4066

WilcoFiers opened this issue Jun 28, 2023 · 0 comments · Fixed by #4114
Assignees
Labels
core Issues in the core code (lib/core) Epic rule metadata Issues in the rule metadata code (lib/rules)
Milestone

Comments

@WilcoFiers
Copy link
Contributor

WilcoFiers commented Jun 28, 2023

The impact of a violation is currently determined by which checks fail. The idea of it was to give some flexibility in setting the impact within the same rule. This never worked well though. Since impact is bound up with the checks of a rule, and which checks run is driven by the remediation message we want to give, axe-core's architecture gives very little control over the impact.

As variable impact is also a common source of confusion, we're going to change this so that a single rule only ever outputs one level of impact. It is already possible to set the impact on a rule, although we aren't using it much.

Since impact is used in many UIs, and we don't want the numbers to drastically change by this release we're going to have to put a few checks into separate rules

Prerequisites

Make impact a required prop on rules/*.json

Once all the above tickets are done, the work for this ticket will be to give each rule an impact property, and make it required in the build tool. We can then do some cleanup in how rule-descriptions.md is generated, as that won't need to look at checks anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues in the core code (lib/core) Epic rule metadata Issues in the rule metadata code (lib/rules)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant