Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move no-implicit-explicit-label check into label-content-name-mismatch rule #4070

Closed
Tracked by #4066
WilcoFiers opened this issue Jun 28, 2023 · 1 comment · Fixed by #4095
Closed
Tracked by #4066

Move no-implicit-explicit-label check into label-content-name-mismatch rule #4070

WilcoFiers opened this issue Jun 28, 2023 · 1 comment · Fixed by #4095
Assignees
Labels
feat New feature or enhancement rule metadata Issues in the rule metadata code (lib/rules) rules Issue or false result from an axe-core rule
Milestone

Comments

@WilcoFiers
Copy link
Contributor

WilcoFiers commented Jun 28, 2023

Part of #4066

The no-implicit-explicit-label check from aria-input/toggle-field-name will be moved to the label-content-name-mismatch experimental rule, and we'll downscale the impact from serious to moderate.

Update

After taking a closer look I no longer think the above was right. no-implicit-explicit-label never fails. It says that code like the following needs review:

<label>
  first name
  <div role="textbox" aria-label="name"></div>
</label>

This actually seems like a serious issue to me, if not critical. I think leaving this at moderate is incorrect. So instead of moving this check to an experimental rule, bumping the impact from moderate to serious is appropriate. User impact will be minimal as needs-review issues aren't counted in impact numbers.

@WilcoFiers WilcoFiers added this to the Axe-core 4.8 milestone Jun 28, 2023
@WilcoFiers WilcoFiers added feat New feature or enhancement rules Issue or false result from an axe-core rule rule metadata Issues in the rule metadata code (lib/rules) labels Jun 28, 2023
@WilcoFiers WilcoFiers self-assigned this Jul 19, 2023
@padmavemulapati
Copy link

Validated using latest axe-core develop branch code base,
for the code:

<label>
  first name
  <div role="textbox" aria-label="name"></div>
</label>

seeing the issue in incomeplete and serious

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or enhancement rule metadata Issues in the rule metadata code (lib/rules) rules Issue or false result from an axe-core rule
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants